fix: preserve Location query params when completing blob uploads#21
Merged
davidpoblador merged 1 commit intomainfrom Apr 2, 2026
Merged
fix: preserve Location query params when completing blob uploads#21davidpoblador merged 1 commit intomainfrom
davidpoblador merged 1 commit intomainfrom
Conversation
httpx's params= replaces the entire query string. Docker Distribution registries include a _state HMAC token in the upload Location URL; dropping it causes 404 "BLOB_UPLOAD_INVALID" on the completing PUT. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
params=replaces the entire query string on a URL. Docker Distribution registries include a_stateHMAC token in the uploadLocationheader; passingparams={"digest": ...}on the completing PUT destroyed this token, causing 404BLOB_UPLOAD_INVALID.digest=to the Location URL directly, preserving any existing query parameters.push_blob_streaming(was untested) and for the_statepreservation on bothpush_blobandpush_blob_streaming.Test plan
push_blobandpush_blob_streamingagainstalltuner-docker-registry.long-python.ts.net🤖 Generated with Claude Code